Improve handling of connection with remote browser using Puppeteer #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… connected to endpoint.
…ser using websocket.
…ocally in Docker.
…for 'disconnected' event. Considering it is not possible to unbind event handler using '.off' until node version 10.
Avoiding unnecessary multiple execution of unit/runner tests with Puppeteer helper.
Contributor
|
Wow! You did a very good job. Thank you for getting this working, documented, and special thanks for tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1350 to improve testing with remote browser instances.
test-helpersservice to simplify writing of tests for helpers, as instructed in CONTRIBUTING.md which was (accidentally) removed with commit da0ecd9.