doc: Fix Pupeteer documentation for waitFroResponse#2632
Merged
Vorobeyko merged 3 commits intocodeceptjs:3.xfrom Oct 26, 2020
Merged
doc: Fix Pupeteer documentation for waitFroResponse#2632Vorobeyko merged 3 commits intocodeceptjs:3.xfrom
Vorobeyko merged 3 commits intocodeceptjs:3.xfrom
Conversation
The predicate method accepts the `response` object and not `request`
Vorobeyko
approved these changes
Oct 25, 2020
Contributor
|
@kulfoniasty please update a corresponding in lib/helpers/Puppeteer.js file |
Contributor
Author
|
@DavertMik fixed. |
Arhell
approved these changes
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The predicate method accepts the
responseobject and notrequestMotivation/Description of the PR
Simple doc update. I believe it is a simple copy&paste mistake.
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)