Skip to content

Conversation

@DavertMik
Copy link
Contributor

Re-implements tests timeouts based on #3059

// timeout for tests in feature to 30s
Feature('', { timeout: 30 })

// timeout a test to 20s
Scenario('', { timeout: 20 })

// timeout a step to 10s
I.limitTime(10).click();

@nikocanvacom
Copy link
Contributor

nikocanvacom commented Nov 4, 2021

Created PR where I fixed force option for stepTimeout plugin and added tests for that option #3117.

force option test is failing now and is not easy to fix because event based approach for step timeout changed the order of timeout updates. Now plugin goes first and then actor so plugin is not in position to make decision whether it need to override existing value when force: true.

Also I don't think implementation should rely on order of event listeners execution. One approach which could resolve this is to return control over selection of the right timeout to step by introducing a setter like step.setTimeout(value, priority)

});

it('should clear any prior existing pages on remote browser', async () => {
xit('should clear any prior existing pages on remote browser', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why xit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, this test constantly fails and I don't know why 🙅

@DavertMik DavertMik merged commit 5ba8b10 into 3.x Nov 10, 2021
@DavertMik DavertMik deleted the timeouts branch November 10, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants