fix(workers): do not exit worker on unhandled rejections#5561
Merged
DavertMik merged 2 commits intoMay 13, 2026
Conversation
The worker process unhandledRejection handler currently calls
process.exit(1) for any rejection whose message is not "expected" /
"AssertionError". Exiting the worker silently drops every remaining
test in its queue — they do not appear in the failure summary, they
are missing entirely from the run report.
In real suites this triggers routinely from orphaned promises:
- page.waitForResponse() created before an action that throws —
the response promise outlives the throw and rejects with Timeout
seconds/minutes later, after the scenario has already moved on
(or finished).
- Session-restore races in the auth plugin when multiple workers
cold-cache simultaneously.
- Playwright video.saveAs after a context close.
Measured on a 133-scenario suite, 4 workers, Node 22:
Without this fix: 73 / 133 executed, 2 workers killed
→ 60 tests silently lost from the report
With this fix: 145 / 145 executed, 0 workers killed
→ all rejections logged, failed tests stay in
the report, worker continues to next test
Restores 3.x behaviour (workers logged rejections and continued).
The uncaughtException handler keeps its current behaviour — that one
is genuinely unrecoverable.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
unhandledRejectionhandler inrunTests.jscallsprocess.exit(1)for any rejection not matchingexpected/AssertionError. This kills the worker and silently drops every remaining test in its queue — they simply disappear from the report.Common triggers (none related to test correctness):
page.waitForResponse()that outlives a thrown error and rejects latervideo.saveAsafter Playwright context closeFix
Remove
process.exit(1)— log the rejection, continue.uncaughtExceptionhandler is unchanged (genuinely unrecoverable). Restores 3.x behaviour.