Skip to content

[WIP] Refactoring #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
galkin merged 32 commits into from
Dec 5, 2017
Merged

[WIP] Refactoring #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
6fb93d3
refactored webdriverio
DavertMik Dec 2, 2017
208a048
refactotred, updated selenium for travis tests
DavertMik Dec 2, 2017
af1fd0b
updated seleniumwebdriver & protractor
DavertMik Dec 2, 2017
ae51683
refactored
DavertMik Dec 3, 2017
ec2f875
refactored Protractor helper
DavertMik Dec 3, 2017
4c26659
refactoring more
DavertMik Dec 4, 2017
76b3491
refactored and merged protractor and webdriver
DavertMik Dec 4, 2017
3538369
codestyle fixes
DavertMik Dec 4, 2017
89d481f
refactored and fixed Nightmare
DavertMik Dec 4, 2017
722d086
codestyles applied
DavertMik Dec 5, 2017
18ac645
merged with master
DavertMik Dec 5, 2017
8077f29
Merge branch 'master' into refactoring
DavertMik Dec 5, 2017
31a2c1a
fixed travis and added retries for tests
DavertMik Dec 5, 2017
d3d210e
Merge branch 'master' into refactoring
DavertMik Dec 5, 2017
4610dd7
fixed Protractor codestyle
DavertMik Dec 5, 2017
486528e
fixed Appium init
DavertMik Dec 5, 2017
b3724fd
fixed Appium test
DavertMik Dec 5, 2017
b780761
fixed tests
DavertMik Dec 5, 2017
ce64ed4
fixed appium execution
DavertMik Dec 5, 2017
0af2d60
fixed fragile grabFromCssProperty test
DavertMik Dec 5, 2017
1d8749d
fixed appium tests, improved error messages
DavertMik Dec 5, 2017
155265c
added back patch to handle accessibility id
DavertMik Dec 5, 2017
1b12a84
added EOL to locator
DavertMik Dec 5, 2017
d300d0e
fixed locator detection in Appium
DavertMik Dec 5, 2017
dbe7ecb
improved accessibility_id
DavertMik Dec 5, 2017
2ca2634
fixed accessibilityId parsing
DavertMik Dec 5, 2017
8cac086
changed quick-second groups
DavertMik Dec 5, 2017
52cc49e
fixed appium tests and locator
DavertMik Dec 5, 2017
3de643c
fixed parsing accessibility id
DavertMik Dec 5, 2017
e048cda
changed locator policy for accessid
DavertMik Dec 5, 2017
894e428
returned back eslint rules
DavertMik Dec 5, 2017
7dadc9b
remocing import/no-unresolved rule. HoundCI can't run checks on it
DavertMik Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
"default-case": 0,
"import/no-extraneous-dependencies": 0,
"no-cond-assign": 0,
"array-callback-return": 0,
"function-paren-newline": 0
"import/no-unresolved": 0,
Copy link
Contributor Author

@DavertMik DavertMik Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hound CI can't parse this rule. Also, it depends on current installation settings so strictly following it won't be helpful.

"no-await-in-loop": 0,
Copy link
Contributor Author

@DavertMik DavertMik Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have loops where await is used following if conditions. There is no clean way to rework it in Promise.all

"arrow-body-style": 0
Copy link
Contributor Author

@DavertMik DavertMik Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes some linex extra long and unreadable

}
}
6 changes: 3 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ env:
matrix:
- HELPER=Protractor
- HELPER=Nightmare
- HELPER=SeleniumWebdriver
- HELPER=ProtractorWeb
- HELPER=WebDriverIO
addons:
apt:
Expand All @@ -20,9 +20,9 @@ addons:
services:
- docker
before_install:
- docker pull selenium/standalone-chrome:2.53.0
- docker pull selenium/standalone-chrome:3.8
before_script:
- docker run -d --net=host selenium/standalone-chrome:2.53.0
- docker run -d --net=host selenium/standalone-chrome:3.8
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start
- chmod -R 777 test/data
Expand Down
3 changes: 2 additions & 1 deletion examples/yahoo_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
Feature('Yahoo test');

Scenario('Nightmare basic test', (I) => {
I.amOnPage('http://yahoo.com');
I.amOnPage('http://127.0.0.1:8000');
pause();
I.fillField('p', 'github nightmare');
I.click('Search Web');
I.waitForElement('#main', 2);
Expand Down
Loading