Closed
Conversation
ElenaStamenkovskaCC
changed the title
ElenaStamenkovskaCC
changed the title
ElenaStamenkovskaCC
changed the title
fvanderflier
pushed a commit
that referenced
this pull request
Mar 11, 2026
* feat: add email service interface and ses implementation * feat: add properties in appsettings * feat: provide template name as a method parameter * fix: remove handling exceptions in service * feat: add fluent validation for aws account check * feat: add unit tests * feat: update nuget package version * feat: use factory pattern for aws client * feat: rename service * fix: rename service in tests --------- Co-authored-by: elenastamenkovska <elena.stamenkovska@halicea.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed?
This MR introduces a decoupled email service architecture using the Dependency Injection (DI) pattern. It integrates Amazon SES (Simple Email Service) for simple and template-based email management.
IEmailService: Defined a new interface for email operations (Template Creation, Sending).AmazonSesService: Provided a concrete implementation using the AWS SDK for .NET (AmazonSESClient).appsettings.json.Why?
We wanted to avoid hardcoding email layouts in our services, so we've implemented Amazon SES. It lets us manage templates directly in AWS, keeping our C# code clean and focused only on the data
Closes #311
Type of Change
How Did You Test This?
I verified these changes by performing an end-to-end test of the email flow using a verified identity in our AWS development environment. I monitored the AWS Console to ensure the templates were correctly registered and used the AWS CLI/Logs to confirm successful delivery.
What I tested:
VerifyEmailIdentityAsynctriggers the verification process in the SES console.CreateEmailTemplateAsynccorrectly registers new templates in the AWS SESEmail templatessection with the expected placeholders.SendEmailAsyncdelivers raw HTML/Text emails to verified recipient addresses.SendTemplatedEmailAsync.How to test it:
If you're testing this locally, make sure your
appsettings.jsonhas a verified SourceEmail and that you are sending to an email address already verified in our SES Sandbox to avoidMessageRejectederrors. Then, try to send some emails.Review Checklist
Screenshots / Additional Context