This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Simplify FileList building #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing algorithm was hard to follow and prone to expanding large directories that should be completely ignored. The new algorithm is the simpler one used by most engines. The only difference in this engine is that we also do glob-filtering on a per-language basis. This used to be configurable, but that fact was not advertised and is likely not being used. The constant was renamed accordingly. This should fix #106
|
LGTM |
|
FYI: I'm seeing a difference in issues found between this and the old image, so I'm looking into that before merging. |
The include_paths may or may not be ./-prefixed (they usually aren't, but there's the notable case of ["./"]). Patterns are never ./-prefixed (they can't be for the purposes of relative expansion). Given this uncertainty, it's possible to drop files if you're not careful in how you match or expand. In addition to this, fingerprints in the wild are all computed with ./-prefixed paths. For all these reasons, we need to normalize the prefixing of paths and patterns in FileList.
|
Fixed with the addition of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing algorithm was hard to follow and prone to expanding large
directories that should be completely ignored. The new algorithm is the simpler
one used by most engines.
The only difference in this engine is that we also do glob-filtering on a
per-language basis. This used to be configurable, but that fact was not
advertised and is likely not being used. The constant was renamed accordingly.
This should fix #106
/cc @codeclimate/review