Custom patterns

[pointlessone]

Example config:

engines:
  duplication:
    enabled: true
    config:
      languages:
        foolang:
          patterns:
          - "*.foofile"
          - "Foofile"

[wfleming]

Code looks good! Nice that the diff is so small.

Aside from my comment about a couple unit tests being nice to have, a larger question: the README here covers most config options, so adding README content for this new option is probably appropriate. Maybe a question for @gordondiggs.

Related to the docs question: in your examples it looks like you've been using simple single-star-with-extension patterns. If we do write docs here it's probably important to make clear that most patterns should be prefixed by **/: all of the current hard-coded patterns do, and without that I think a pattern will only match files in the root dir of the repo.

[wfleming]

Nice simple way of ensuring you get the type you want, cool. 👍

[wfleming]

The integration-y test you have is great. Would it be reasonable to get some unit tests as well? For example, in addition to the happy path, it'd be nice to have a test that a malformed config like:

ruby:
  patterns: "*.rb"

does the right thing. (I think your code does handle this quite nicely, but guarding against future regressions with a test would be nice.)

[wfleming]

This looks like a good bugfix in its own right, and not directly related to the new feature. It's already in its own commit, so I'd support cherry-picking this into a new branch & shipping it separately as its own PR if you want to.

Also, it's been many years since I wrote much PHP, so pardon if this is a silly question: this won't stop us from seeing exceptions/stack traces in logs if the parser crashes, will it?

[pointlessone]

PHP duplication specs were failing for me because notices polluted the output. This is definitely setup issue but I don't know if CI has similar setup to that of mine. I can extract this commit and see how CI will react to that.

It might be that without this change CI will fail this PR build.