Updated channel and documentation to Rubocop v0.79.0 #222
+144
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. I just unassigned myself. We'll need to get someone else to review @filipesperandio 👌 |
Contributor
Author
|
👍 Just waiting the 78 to get reviewed first, as this use those changes as a baseline. |
filipesperandio
added a commit
to DanielWright/codeclimate-rubocop
that referenced
this pull request
Feb 27, 2020
* Updated channel and documentation to Rubocop v0.79.0 (codeclimate#222) * Bumps 'rubocop' Dependency to v0.80.0 * Updates Scraped Documentation * Handles Edge-Case in Documentation Parsing Logic If a cop's documentation grows too long (e.g. Style/BlockDelimiters), it will run afoul of the Metrics/ClassLength cop, which will need to be disabled. This breaks the parsing. Adjusting the initial gsub's regexp pattern appears to resolve this edge-case. * Minor Delinting * Fixes Namespace Warnings in Config Files * Possible Fix for Config Upgrader Spec I'm not sure what the desired outcome here is, actually. * Updates ConfigUpgrader Spec Per feedback from @filipesperandio, the config upgrader spec will now exercise the upgrades with the new cops enabled, rather than disabled. Co-authored-by: Filipe Esperandio <filipesperandio@gmail.com>
filipesperandio
added a commit
that referenced
this pull request
Feb 27, 2020
* Updated channel and documentation to Rubocop v0.79.0 (#222) * Bumps 'rubocop' Dependency to v0.80.0 * Updates Scraped Documentation * Handles Edge-Case in Documentation Parsing Logic If a cop's documentation grows too long (e.g. Style/BlockDelimiters), it will run afoul of the Metrics/ClassLength cop, which will need to be disabled. This breaks the parsing. Adjusting the initial gsub's regexp pattern appears to resolve this edge-case. * Minor Delinting * Fixes Namespace Warnings in Config Files * Possible Fix for Config Upgrader Spec I'm not sure what the desired outcome here is, actually. * Updates ConfigUpgrader Spec Per feedback from @filipesperandio, the config upgrader spec will now exercise the upgrades with the new cops enabled, rather than disabled. * Removes New Cops from Base Config Co-authored-by: Filipe Esperandio <filipesperandio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.