Skip to content

Conversation

@maxjacobson
Copy link
Contributor

I already rolled back to the earlier rubocop in production, but I want to make it official here as well.

This change was very disruptive because the default inferred .rubocop.yml wasn't compatible with some changes in cop configuration. We need to update our default inferred .rubocop.yml in tandem with re-shipping the rubocop upgrade to minimize that disruption.

It was also somewhat disruptive to users who have hardcoded configuration files because their builds start to error if their configuration isn't compatible with the newer version, but was compatible with the older version. I'm glad the rubocop error messages when this occurs are good and can guide these users to fixing their configuration for the upgraded version. I'll try and think of how we can minimize that disruption before re-shipping it.

@maxjacobson maxjacobson merged commit 8479b37 into master Feb 14, 2017
@maxjacobson maxjacobson deleted the mj/revert branch February 14, 2017 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants