Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Shorten test coverage status #126

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Shorten test coverage status #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cc/presenters/pull_requests_presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def skipped_message
end

def coverage_message
message = "#{formatted_percent(@covered_percent)}% test coverage"
message = "#{formatted_percent(@covered_percent)}%"

if @covered_percent_delta > 0
message += " (+#{formatted_percent(@covered_percent_delta)}%)"
Expand Down
6 changes: 3 additions & 3 deletions spec/cc/presenters/pull_requests_presenter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@
end

it "message coverage same" do
expect("85% test coverage").to eq(build_presenter({}, "covered_percent" => 85, "covered_percent_delta" => 0).coverage_message)
expect("85%").to eq(build_presenter({}, "covered_percent" => 85, "covered_percent_delta" => 0).coverage_message)
end

it "message coverage up" do
expect("85.5% test coverage (+2.46%)").to eq(build_presenter({}, "covered_percent" => 85.5, "covered_percent_delta" => 2.4567).coverage_message)
expect("85.5% (+2.46%)").to eq(build_presenter({}, "covered_percent" => 85.5, "covered_percent_delta" => 2.4567).coverage_message)
end

it "message coverage down" do
expect("85.35% test coverage (-3%)").to eq( build_presenter({}, "covered_percent" => 85.348, "covered_percent_delta" => -3.0).coverage_message)
expect("85.35% (-3%)").to eq( build_presenter({}, "covered_percent" => 85.348, "covered_percent_delta" => -3.0).coverage_message)
end

private
Expand Down
2 changes: 1 addition & 1 deletion spec/cc/service/github_pull_requests_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@

it "pull request coverage status" do
expect_status_update("pbrisbin/foo", "abc123", "state" => "success",
"description" => "87% test coverage (+2%)")
"description" => "87% (+2%)")

receive_pull_request_coverage({},
github_slug: "pbrisbin/foo",
Expand Down
2 changes: 1 addition & 1 deletion spec/cc/service/gitlab_merge_requests_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"hal/hal9000",
"abc123",
"state" => "success",
"description" => "87% test coverage (+2%)",
"description" => "87% (+2%)",
)

receive_merge_request_coverage(
Expand Down