Add eslintrc #28
Merged
Add eslintrc #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We already have an eslintrc config |
jpignata
force-pushed
the
jp/add-eslintrc
branch
from
a1c58bc to
cff447f
Compare
Contributor
Author
|
Ahh, I missed this by just glancing at the |
Contributor
Author
|
@gordondiggs I'd like to allow us to use trailing commas on node projects for the same reason we do it within Ruby. I see there's a compatibility issues with versions of IE less than 8 with this behavior, but I'm not certain we actually support > IE 8? Opinions? |
Contributor
|
@jpignata I'm +1 on that |
Contributor
Author
|
@gordondiggs Done. |
Contributor
|
LGTM |
* Add trailing commas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from the default configuration we generate via codeclimate with
the small change of allowing trailing commas (comma-dangle).
@codeclimate/review