Enforce double quotes for strings all the time. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule seems like a strange exception to our normal "always double
quotes" practice. It also leads to (to me) visually confusing code when
methods dealing with strings appear in #{} blocks. I suggest me make
this also require double quotes so everything is consistent.
Contributor
|
Agreed. I'd consider it an oversight this rule wasn't already present (seems a weird distinction for rubocop to make). |
wfleming
added a commit
that referenced
this pull request
Mar 15, 2016
Enforce double quotes for strings all the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule seems like a strange exception to our normal "always double
quotes" practice. It also leads to (to me) visually confusing code when
methods dealing with strings appear in #{} blocks. I suggest we make
this also require double quotes so everything is consistent.
cc @codeclimate/review