Enable rails cops #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Ruby | ||
|
|
||
| ## Rubocop | ||
| ## RuboCop |
ruby/README.md
Outdated
| "rulers": [ 80 ] | ||
| ``` | ||
|
|
||
| [external configuration]: https://codeclimate.com/changelog/582495c32c33066f1b00191d |
Contributor
There was a problem hiding this comment.
wdyt about linking to the doc instead of the changelog?
I think that makes sense for internal policy but nbd either way - easy to get from changelog to doc in any case, so up to you!
Contributor
Author
There was a problem hiding this comment.
Oo yea I do prefer that. Updated
I noticed that in our Rails app, we explicitly enable some Rails cops, but without this bit, those cops aren't actually enabled. This change also enables a number of _other_ Rails cops, some of which I suppose we aren't necessarily enthusiastic about. The one I specifically was eager to enable was Rails/ActionFilter... I'd like to open a PR against our Rails apps to use this new flow and see what issues they sniff out and then revisit disabling some cops at that point.
Contributor
|
One minor suggestion. LGTM. Do we need two LGTMs on styleguide changes as a practice? |
maxjacobson
force-pushed
the
mj/enable-rails-cops
branch
from
eefed72 to
55b4eb9
Compare
Contributor
Author
|
Do we? I'll solicit another :) |
|
Surprised that Rails rules need to be disabled in the default |
Contributor
Author
|
@nporteschaikin I suppose they don't, since they're disabled by default. I kept that basically to make it explicit that that's what's happening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in our Rails app, we explicitly enable some Rails cops,
but without this bit, those cops aren't actually enabled.
This change also enables a number of other Rails cops, some of which I
suppose we aren't necessarily enthusiastic about.
The one I specifically was eager to enable was Rails/ActionFilter... I'd
like to open a PR against our Rails apps to use this new flow and see
what issues they sniff out and then revisit disabling some cops at that
point.