feat: funcionalidade tela cheia, botão editar e correção no código#2
Merged
gabrnunes merged 1 commit intocodecon-dev:mainfrom Mar 17, 2025
Merged
feat: funcionalidade tela cheia, botão editar e correção no código#2gabrnunes merged 1 commit intocodecon-dev:mainfrom
gabrnunes merged 1 commit intocodecon-dev:mainfrom
Conversation
geanfarias
reviewed
Mar 17, 2025
Comment on lines
+56
to
+69
| if (seconds === 0) { | ||
| if (minutes > 0) { | ||
| minutes--; | ||
| seconds = 59; | ||
| } else if (hours > 0) { | ||
| hours--; | ||
| minutes = 59; | ||
| seconds = 59; | ||
| } else { | ||
| // Timer acabou | ||
| timerStarted = false; | ||
| clearInterval(intervalInstance); | ||
| intervalInstance = null; | ||
| return; |
Member
There was a problem hiding this comment.
dá para melhorar essa função sem precisar de tantos ifs, vou subir um ajuste para isso apontando para eu pr
Contributor
Author
There was a problem hiding this comment.
Vai nessa, fure a bolha 😁✌ e vai com tudo @geanfarias
geanfarias
reviewed
Mar 17, 2025
Comment on lines
+128
to
+130
| document.getElementById("hour").value = hours; | ||
| document.getElementById("min").value = minutes; | ||
| document.getElementById("sec").value = seconds; |
Member
There was a problem hiding this comment.
o finish deveria fazer com que os inputs tenham os seguintes valores: 00:00:30
Contributor
Author
There was a problem hiding this comment.
Boa, valeu pela dica, captei mano.
geanfarias
approved these changes
Mar 17, 2025
Member
geanfarias
left a comment
geanfarias
left a comment
There was a problem hiding this comment.
@gabrnunes, as melhorias não adicionadas aqui foram feitas nos outros prs já abertos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Funcionalidade tela cheia, botão editar e coreção no código.
Agora vai certo @gabrnunes ?