fix: resolve 104 clippy::pedantic warnings (175→71)#138
Merged
Conversation
Machine-applicable fixes by cargo clippy --fix: - format string interpolation (variables inline) - redundant closures - unnecessary raw string hashes - missing doc backticks - if-let instead of single-pattern match - Clone::clone → clone_from suggestions - trivially_copy_pass_by_ref - format_collect → join - etc. Closes #84 (partial)
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-cli · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Auto-fix 104 of 175 clippy::pedantic warnings using
cargo clippy --fix.Remaining (71)
Will be addressed in follow-up PRs:
format_push_string(28) — needs manualwrite!conversionassigning_clones(11) — needs manualclone_from()too_many_lines(4) — function split or allowfloat_cmp(4) — test assertions, allowcast_*(4) — intentional casts, allowmanual_let_else(4) — pattern conversionVerification
cargo clippy --all-targets -- -D warningscleancargo fmt --all -- --checkcleanPartially closes #84