fix: resolve remaining clippy pedantic warnings (71→0)#139
Merged
Conversation
Changes: - providers.rs: remove unnecessary Result wrapper - review.rs: allow struct_excessive_bools, cast_possible_truncation - scan.rs: let...else pattern, allow too_many_lines, format_collect - upload.rs: allow items_after_statements, cast_precision_loss - loader.rs: let...else pattern, allow too_many_lines + casts - schema.rs: clone_from() for merge_into, allow float_cmp in tests - cache.rs: allow format_collect - llm.rs: allow struct_field_names, too_many_lines, format_push_string, doc_backticks - review.rs: let...else pattern - scanner.rs: allow unnecessary_wraps, format_push_string - types.rs: self by value, merge match arms, allow float_cmp - compact.rs: allow format_push_string - pretty.rs: allow format_push_string - sarif.rs: merge identical match arms - main.rs: allow too_many_lines, struct_excessive_bools, ref_option
🔍 Cora AI Code Review❌ Blocked — critical issues found. 🔴 Error (1)
Review powered by cora-cli · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes #84 — zero clippy::pedantic warnings remaining.
Summary: All 71 remaining pedantic warnings resolved:
Checks: 224 tests ✅, clippy pedantic 0 warnings ✅, fmt clean ✅