Skip to content

redirect error messages to STDERR#31

Merged
giovanni-guidini merged 2 commits intomainfrom
gio/logging-to-stderr
Dec 28, 2023
Merged

redirect error messages to STDERR#31
giovanni-guidini merged 2 commits intomainfrom
gio/logging-to-stderr

Conversation

@giovanni-guidini
Copy link
Copy Markdown
Contributor

According to Shell Style Guide,
all error messages should go to stderr (see here)

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (8633d98) 47.92% compared to head (8b9bf39) 47.48%.

Files Patch % Lines
dist/codecov_ats.sh 0.00% 7 Missing ⚠️
src/codecov_ats.sh 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   47.92%   47.48%   -0.44%     
==========================================
  Files           7        7              
  Lines         217      219       +2     
==========================================
  Hits          104      104              
- Misses        113      115       +2     
Flag Coverage Δ
bash 37.70% <0.00%> (-0.42%) ⬇️
smart-tests 97.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasrockhu-codecov
Copy link
Copy Markdown
Collaborator

@giovanni-guidini this is fine, but can we have a run showing what it would actually look like on CI? I'm pretty sure stderr also logs on GHA, but I just want to make sure

Copy link
Copy Markdown
Collaborator

@thomasrockhu-codecov thomasrockhu-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do a run that shows that stderror actually does print out to the GHA console

@giovanni-guidini
Copy link
Copy Markdown
Contributor Author

Just do a run that shows that stderror actually does print out to the GHA console

https://github.com/codecov/codecov-ats/actions/runs/7348125288/job/20005671013

@giovanni-guidini giovanni-guidini merged commit bb85483 into main Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants