Conversation
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 91.71% 90.47% -1.24%
==========================================
Files 1 1
Lines 338 357 +19
==========================================
+ Hits 310 323 +13
- Misses 28 34 +6
Continue to review full report at Codecov.
|
It's very dangerous and unstable to have dependencies without any version lock, they may update at any time and without backward compatibility.
053fba0 to
e1905d1
Compare
Ruby 3.0 will be released in less than a month, are your sure this is good idea? |
This is a major release, and usually it means it backward incompatible. Yes, many of gems can work with Ruby 3, but we can't be sure, breaking changes can be included at any moment before stable release (yeah, it's less likely with release candidates, but still). After the release we can include Ruby 3 in CI, ensure that everything works fine, maybe fix something, and change version lock to Again, simple We should be careful with this. |
|
@AlexWayfer Is there a reason simplceov requirement locked on '~> 0.18.0' in this PR? This is the reason for this issue |
Thank you, responded there. Shortly, the reason the same as for required Ruby version: |
@AlexWayfer Was giving it a shot to relax the dependency and all tests are green. Anything else we should be looking into? |
IDK. Unfortunately, there can be errors out of CI, like #119. Also I saw the article today about performance issue with threads, which is worse with Ruby 3: https://mensfeld.pl/2020/12/the-hidden-cost-of-a-ruby-threads-leakage/ But I don't think it's related, of course, and a breaking problem. Also Codecov gem code is pretty simple, it's not hard to test and check. And if CI is green — I think it's ready to go. I'm just noticing that there can be problems anyway, even with passing CI, but it's easier for us to rely on CI. And Ruby 3 has backward incompatible changes, like with keyword arguments (I had problems with them since 2.7), so major releases not just for beauty, but also has meaning. And not every major release breaks every code, of course. But it can — that's why there is should be limitation. |
|
@AlexWayfer Thanks for the insight! I'll issue a PR (a bit more conservative, using This will allow people trying to upgrade to Ruby 3.0.0 to move on if they want to and allow us to keep track of possible errors. So far my test runs on Ruby 3 don't produce any warnings related to keyword arguments, in fact during the migration to Ruby 2.7 we were already warned about those. |
summaryanddescriptionrequire_pathsandtest_filesIt's very dangerous and unstable to have dependencies without any version lock,
they may update at any time and without backward compatibility.