Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Specify gem version only once#40

Merged
thomasrockhu merged 8 commits intocodecov:masterfrom
meganemura:version
Aug 6, 2020
Merged

Specify gem version only once#40
thomasrockhu merged 8 commits intocodecov:masterfrom
meganemura:version

Conversation

@meganemura
Copy link
Copy Markdown
Contributor

and fix gem version to current rubygems' one.

@thomasrockhu thomasrockhu self-requested a review August 6, 2020 22:22
Copy link
Copy Markdown
Contributor

@thomasrockhu thomasrockhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not have been your original intent, but I think there was some strange dependency going on with Simplecov.

@thomasrockhu
Copy link
Copy Markdown
Contributor

Thanks for this @meganemura!

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 6, 2020

Codecov Report

Merging #40 into master will decrease coverage by 1.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   90.47%   88.98%   -1.49%     
==========================================
  Files           1        1              
  Lines         336      336              
==========================================
- Hits          304      299       -5     
- Misses         32       37       +5     
Impacted Files Coverage Δ
lib/codecov.rb 88.98% <100.00%> (-1.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe7460...d3b21ab. Read the comment docs.

@thomasrockhu thomasrockhu merged commit c0db3b2 into codecov:master Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants