Properly handle 400 cases when using the v4 endpoint by thomasrockhu · Pull Request #74 · codecov/codecov-ruby

thomasrockhu · 2020-07-14T23:40:03Z

No description provided.

codecov · 2020-07-14T23:57:19Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-14T23:58:20Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-14T23:58:24Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-14T23:58:45Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-14T23:58:52Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-14T23:58:56Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-14T23:58:57Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-14T23:59:15Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

drazisil

codecov · 2020-07-14T23:59:30Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-14T23:59:34Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-14T23:59:36Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-14T23:59:44Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-14T23:59:57Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-15T00:00:09Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-15T00:00:16Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

codecov · 2020-07-15T00:00:20Z

Codecov Report

Merging #74 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   89.34%   89.53%   +0.19%     
==========================================
  Files           1        1              
  Lines         319      325       +6     
==========================================
+ Hits          285      291       +6     
  Misses         34       34

Impacted Files	Coverage Δ
lib/codecov.rb	`89.53% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a9b7...e84f6f8. Read the comment docs.

thomasrockhu · 2020-07-15T00:01:13Z

I'm not sure why the Travis check isn't showing, but the build is here: https://travis-ci.org/github/codecov/codecov-ruby/builds/708172505

Properly handle 400 cases when using the v4 endpoint

1dfddc5

thomasrockhu requested a review from drazisil July 14, 2020 23:40

Fix tests

e84f6f8

thomasrockhu force-pushed the 0.2.1 branch from 9fd47dc to e84f6f8 Compare July 14, 2020 23:50

Conversation

thomasrockhu commented Jul 14, 2020

Uh oh!

codecov Bot commented Jul 14, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 14, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 14, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 14, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 14, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 14, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 14, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 14, 2020

Codecov Report

Uh oh!

drazisil left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jul 14, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 14, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 14, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 14, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 14, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 15, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 15, 2020

Codecov Report

Uh oh!

codecov Bot commented Jul 15, 2020

Codecov Report

Uh oh!

thomasrockhu commented Jul 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants