This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Fix jruby-9.1.x compatibility#79
Merged
thomasrockhu merged 4 commits intocodecov:masterfrom Jul 27, 2020
mainameiz:fix-compatibility-with-jruby-9.1.12.0
Merged
Fix jruby-9.1.x compatibility#79thomasrockhu merged 4 commits intocodecov:masterfrom mainameiz:fix-compatibility-with-jruby-9.1.12.0
thomasrockhu merged 4 commits intocodecov:masterfrom
mainameiz:fix-compatibility-with-jruby-9.1.12.0
Conversation
mainameiz
changed the title
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 88.65% 90.24% +1.59%
==========================================
Files 1 1
Lines 326 328 +2
==========================================
+ Hits 289 296 +7
+ Misses 37 32 -5
Continue to review full report at Codecov.
|
mainameiz
changed the title
thomasrockhu
approved these changes
Jul 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While making a PR into aasm. I found that new version of codecov does not work in jruby 9.1.x (9.1.12.0 actually).
You can find failed build on travis-ci.org in the first commit in this PR.
Reason is that
GzipWriter#closedoes not return instance of underlying IO-like object.It was broken in 0.1.20 release here.
Changes:
First commit in this PR adds jruby 9.1.12.0 into
.travis.ymlto show that it fails before changes and passes after fixing.