fix: content layout shift fix, form label common component, and other changes#2899
Open
sashaboi wants to merge 2 commits intocodecov:mainfrom
Open
fix: content layout shift fix, form label common component, and other changes#2899sashaboi wants to merge 2 commits intocodecov:mainfrom
sashaboi wants to merge 2 commits intocodecov:mainfrom
Conversation
Author
|
@nicholas-codecov how could i make your job easy as a reviewer? should I break down each change into separate prs and videos, so it would be easier to review and merge? |
Contributor
|
Sorry @sashaboi, I've been a bit busy getting caught back up with things after a couple days PTO, I'm taking a peak now. |
Collaborator
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I have added a few things :
/account/github/<username>which gave a bit of a content shift for the first tabsrc/pages/AnalyticsPage/ChartSelectors/ChartSelectors.jsxmade uniformDescription
Video explanation : https://github.com/codecov/gazebo/assets/75421090/3abefbd7-3cd1-4d5f-9452-7c08519f909d
Notable Changes
Addition of
FormLabelcomponent & testsDisclaimer
Most of these are nitpicks but as a frontend person these keep me up at night 💀
Finally found time now to pick these after going through Codecov during my interview at Sentry last month.
This is my fun account , I have earlier contributed through @onkardeshpande93
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.