-
Notifications
You must be signed in to change notification settings - Fork 11
feat: move timeseries app from api to shared #500
Conversation
adrian-codecov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, have you been following this guide? https://www.notion.so/sentry/Migration-Guide-74712fa52fad404babc02543db72278b
I'd also check for timeseries related DB settings that you might be needing to add to Shared so these models also work in Worker.
And, as part of moving this, could you also remove basically everything you moved from API? The guide I believe should have documentation on how to do so as well
1118b88 to
4030164
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 90.39% 89.97% -0.43%
==========================================
Files 444 324 -120
Lines 13031 9045 -3986
Branches 2109 1599 -510
==========================================
- Hits 11780 8138 -3642
+ Misses 1131 846 -285
+ Partials 120 61 -59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swatinem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! I wanted to add this to the owner / repo delete task as well, so this will help with that.
✅ Sentry found no issues in your recent changes ✅ |
I want to be able to access the timeseries models in worker using Django.