Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Conversation

@joseph-sentry
Copy link
Contributor

I want to be able to access the timeseries models in worker using Django.

@joseph-sentry joseph-sentry requested a review from a team February 5, 2025 17:54
Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, have you been following this guide? https://www.notion.so/sentry/Migration-Guide-74712fa52fad404babc02543db72278b

I'd also check for timeseries related DB settings that you might be needing to add to Shared so these models also work in Worker.

And, as part of moving this, could you also remove basically everything you moved from API? The guide I believe should have documentation on how to do so as well

@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.97%. Comparing base (7ba099f) to head (4030164).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   90.39%   89.97%   -0.43%     
==========================================
  Files         444      324     -120     
  Lines       13031     9045    -3986     
  Branches     2109     1599     -510     
==========================================
- Hits        11780     8138    -3642     
+ Misses       1131      846     -285     
+ Partials      120       61      -59     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I wanted to add this to the owner / repo delete task as well, so this will help with that.

@joseph-sentry joseph-sentry added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 838bba5 Feb 6, 2025
6 checks passed
@joseph-sentry joseph-sentry deleted the joseph/timeseries branch February 6, 2025 14:35
@JerrySentry JerrySentry restored the joseph/timeseries branch March 11, 2025 21:07
JerrySentry added a commit that referenced this pull request Mar 11, 2025
@overwatch-beta
Copy link

overwatch-beta bot commented Mar 11, 2025

✅ Sentry found no issues in your recent changes ✅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants