Clean up Storage code

[Swatinem]

This removes the old storage abstractions including all their tests.

And also inlines the minio adapter read/write implementation back into the base class.

[ghost]

⏳ Sentry is currently working on detecting potential issues in your PR ⏳

Results will appear when the job is complete.

[codspeed-hq]

CodSpeed Performance Report

Merging #570 will not alter performance

_{Comparing swatinem/cleanup-storage (fb2c910) with main (e30c1c7)}

Summary

✅ 9 untouched benchmarks

[codecov]

Codecov Report

Attention: Patch coverage is 82.14286% with 10 lines in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (284b92c) to head (fb2c910).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
shared/storage/minio.py	82.14%	7 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   88.62%   88.94%   +0.31%     
==========================================
  Files         462      457       -5     
  Lines       13183    12934     -249     
  Branches     1513     1484      -29     
==========================================
- Hits        11684    11504     -180     
+ Misses       1181     1123      -58     
+ Partials      318      307      -11     

Flag	Coverage Δ
shared-docker-uploader	88.94% <82.14%> (+0.31%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joseph-sentry]

just some comments about possible future improvements

[joseph-sentry]

may be good in a follow up to remove the BaseStorageService as well, it was only useful to define an interface when we had multiple implementations, now that we only have one, it's not as usefule, same with the PresignedURLService as well

[joseph-sentry]

i guess this can be done in a follow-up but we should "deprecate" this argument, maybe using overloads and https://typing.python.org/en/latest/spec/directives.html#example

[seer-by-sentry]

⏳ Sentry is currently working on detecting potential issues in your PR ⏳

Results will appear when the job is complete.

[codecov-notifications]

Codecov Report

Attention: Patch coverage is 82.14286% with 10 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
shared/storage/minio.py	82.14%	7 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

[Swatinem]

Thanks for the suggestions. I removed the instrumentation from this PR.

And I agree that merging / removing the abstract base class / inferface is a good followup that I do want to do, along with cleaning up the various usages and parameters. That would likely need a few passes, as it also means having to audit/update all usage sites.