Remove more unused Report code, change serde code to use str#575
Remove more unused Report code, change serde code to use str#575
Report code, change serde code to use str#575Conversation
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
==========================================
- Coverage 88.88% 88.88% -0.01%
==========================================
Files 457 457
Lines 12867 12840 -27
Branches 1469 1467 -2
==========================================
- Hits 11437 11413 -24
+ Misses 1126 1123 -3
Partials 304 304
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #575 will improve performances by 24.67%Comparing Summary
Benchmarks breakdown
|
|
This fixes most of the regressions from #553 (comment) it would seem. |
I removed the users of the
to_archive/to_databasefunctions, so lets remove those, along with other functions.Another change is to change the serde code to use
str. As strange as it might sound, but I believe that python is optimizing strings a bit better, and avoids copying all the string contents around in some cases.This also cleans up the tests a bit.