Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

remove overwatch#576

Merged
giovanni-guidini merged 1 commit intomainfrom
gio/rm-overwatch
Mar 18, 2025
Merged

remove overwatch#576
giovanni-guidini merged 1 commit intomainfrom
gio/rm-overwatch

Conversation

@giovanni-guidini
Copy link
Copy Markdown
Contributor

"shared" doesn't have an appropriate sentry project for its code. So overwatch, as it is now, can't really give any useful feedback.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

"shared" doesn't have an appropriate sentry project for its code.
So overwatch, as it is now, can't really give any useful feedback.
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (9d1b9b1) to head (45ca688).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files         457      457           
  Lines       12840    12840           
  Branches     1467     1467           
=======================================
  Hits        11413    11413           
  Misses       1123     1123           
  Partials      304      304           
Flag Coverage Δ
shared-docker-uploader 88.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications Bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 18, 2025

CodSpeed Performance Report

Merging #576 will not alter performance

Comparing gio/rm-overwatch (45ca688) with main (9d1b9b1)

Summary

✅ 9 untouched benchmarks

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit e121816 Mar 18, 2025
12 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/rm-overwatch branch March 18, 2025 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants