Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Comments

Document broken branch merging logic#585

Merged
Swatinem merged 1 commit intomainfrom
swatinem/broken-branchmerge
Mar 26, 2025
Merged

Document broken branch merging logic#585
Swatinem merged 1 commit intomainfrom
swatinem/broken-branchmerge

Conversation

@Swatinem
Copy link
Contributor

This is coming from a customer issue.
The customer has an upload that contains both an lcov file as well as a cobertura file.

The lcov file creates a LineSession with 0/2 coverage and missed_branches=[0:5, 0:6].
The cobertura file encodes the same information in a different format, yielding 0/1 with missed_braches=[0].

Merging those two is currently broken and yields a bogus result of 2/2.

@Swatinem Swatinem requested a review from a team March 25, 2025 10:53
@Swatinem Swatinem self-assigned this Mar 25, 2025
@codecov-notifications
Copy link

codecov-notifications bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (fd909cc) to head (360a256).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   88.58%   88.58%           
=======================================
  Files         462      462           
  Lines       12873    12873           
  Branches     1461     1461           
=======================================
  Hits        11403    11403           
  Misses       1165     1165           
  Partials      305      305           
Flag Coverage Δ
shared-docker-uploader 88.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 25, 2025

CodSpeed Performance Report

Merging #585 will not alter performance

Comparing swatinem/broken-branchmerge (360a256) with main (fd909cc)

Summary

✅ 9 untouched benchmarks

@Swatinem Swatinem added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit 5270a1b Mar 26, 2025
12 checks passed
@Swatinem Swatinem deleted the swatinem/broken-branchmerge branch March 26, 2025 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants