This repository was archived by the owner on May 5, 2025. It is now read-only.
Replace torngit_cache with the regular one#598
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
==========================================
- Coverage 88.64% 88.59% -0.05%
==========================================
Files 464 463 -1
Lines 12839 12784 -55
Branches 1464 1458 -6
==========================================
- Hits 11381 11326 -55
Misses 1153 1153
Partials 305 305
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #598 will not alter performanceComparing Summary
|
The `torngit_cache` was never active, as our production config has never enabled the `vcs_cache.enabled` flag. Apart from that, the cache was used for status checks and check suites, which is something that we actively poll for changes, as it is changing as a result of CI runs. In contrast, commits, diffs and comparisons are immutable, and a good target to cache, so lets do that.
Swatinem
force-pushed
the
swatinem/better-torngitcache
branch
from
113cb1d to
b0cafe8
Compare
giovanni-guidini
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
torngit_cachewas never active, as our production config has never enabled thevcs_cache.enabledflag.Apart from that, the cache was used for status checks and check suites, which is something that we actively poll for changes, as it is changing as a result of CI runs.
In contrast, commits, diffs and comparisons are immutable, and a good target to cache, so lets do that.
Based on #597