Skip to content

Conversation

@drazisil-codecov
Copy link
Contributor

In additional to making max_retries values for bundle_analysis that can be configured, this fix will also add missing max_retries to any tasks already queued before deployment

@drazisil-codecov drazisil-codecov marked this pull request as ready for review December 9, 2025 14:17
@codecov-eu
Copy link

codecov-eu bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/tasks/bundle_analysis_notify.py 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/tasks/bundle_analysis_notify.py 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025

CodSpeed Performance Report

Merging #603 will not alter performance

Comparing fix/add-max_retries-to-tasks-missing-it (e855bfb) with main (e0e610a)

Summary

✅ 9 untouched

@sentry
Copy link

sentry bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.87%. Comparing base (e0e610a) to head (e855bfb).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/tasks/bundle_analysis_notify.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files        1284     1284           
  Lines       46667    46670    +3     
  Branches     1522     1522           
=======================================
+ Hits        43809    43812    +3     
  Misses       2548     2548           
  Partials      310      310           
Flag Coverage Δ
apiunit 96.57% <ø> (ø)
sharedintegration 38.80% <100.00%> (+<0.01%) ⬆️
sharedunit 88.77% <100.00%> (+<0.01%) ⬆️
workerintegration 58.60% <80.00%> (+<0.01%) ⬆️
workerunit 91.21% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drazisil-codecov drazisil-codecov added this pull request to the merge queue Dec 9, 2025
Merged via the queue into main with commit bb2c900 Dec 9, 2025
53 of 56 checks passed
@drazisil-codecov drazisil-codecov deleted the fix/add-max_retries-to-tasks-missing-it branch December 9, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants