fix(worker): Fix infinite retry loop in bundle analysis processor

[drazisil-codecov]

Description

Fixes the infinite retry loop bug in BundleAnalysisProcessorTask that was causing tasks to retry indefinitely. This is a minimal atomic change extracted from PR #608.

Root Cause:
The task was using self.attempts instead of self.request.retries when calling LockManager.locked(). The self.attempts property can be inconsistent with self.request.retries due to visibility timeout re-deliveries, causing the max retries check to fail and allowing infinite retries.

Changes:

• Changed retry_num=self.attempts to retry_num=self.request.retries in LockManager.locked() call
• Removed max_retries parameter (no longer accepted by LockManager)
• Simplified exception handler to use centralized self.retry() method which properly checks max retries

Impact:

• Prevents infinite retries when max retries are exceeded
• Uses consistent retry counting via self.request.retries
• Leverages centralized retry logic in BaseCodecovTask.retry()

Related:

• Addresses looping retry issue seen in task logs (e.g., task id b5d5eefe-adea-48da-a4a4-c5992bf48375)
• Part of the retry logic improvements in PR feat(worker): Centralize retry logic in BaseCodecovTask and fix infinite retry bugs #608

---

Note

Resolves runaway retries in bundle analysis processing and hardens retry behavior.

• In bundle_analysis_processor.py, pass retry_num=self.request.retries to LockManager.locked() and handle LockRetry by checking self.request.retries >= max_retries; on exceed, return previous_result, otherwise call self.retry() with backoff
• Preserve chain behavior by returning previous_result when lock retries are exhausted; remove legacy safe_retry usage in favor of centralized self.retry()
• Add integration tests validating processor→notify chain success and max-retries handling (test_bundle_analysis_e2e.py)
• Update unit tests to assert new retry semantics (raising Retry below max, returning previous_result at/above max) and error-state persistence on processing failures (test_bundle_analysis_processor_task.py)

^{Written by Cursor Bugbot for commit 78a77b5. This will update automatically on new commits. Configure here.}

[sentry]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.90%. Comparing base (aca0c54) to head (78a77b5).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
+ Coverage   93.89%   93.90%   +0.01%     
==========================================
  Files        1286     1286              
  Lines       46807    46802       -5     
  Branches     1517     1517              
==========================================
  Hits        43951    43951              
+ Misses       2547     2542       -5     
  Partials      309      309              

Flag	Coverage Δ
workerintegration	59.10% <50.00%> (+0.83%)	⬆️
workerunit	91.30% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codecov-notifications]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!