refactor: break up StatusNotifier.notify into focused methods [1/4]#694
Draft
thomasrockhu-codecov wants to merge 1 commit intomainfrom
Draft
refactor: break up StatusNotifier.notify into focused methods [1/4]#694thomasrockhu-codecov wants to merge 1 commit intomainfrom
thomasrockhu-codecov wants to merge 1 commit intomainfrom
Conversation
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
=======================================
Coverage 92.34% 92.34%
=======================================
Files 1302 1302
Lines 47805 47818 +13
Branches 1619 1619
=======================================
+ Hits 44146 44159 +13
Misses 3350 3350
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Extract StatusNotifier.notify() (98 lines) into focused methods under 50 lines each. - _check_notify_preconditions(): validates branches/builds requirements - _build_payload_with_behavior(): builds payload applying flag coverage rules - _set_payload_url(): sets URL based on PR or commit context Co-authored-by: Cursor <cursoragent@cursor.com>
thomasrockhu-codecov
force-pushed
the
refactor/status-notifier-breakup
branch
from
4935682 to
268f901
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts
StatusNotifier.notify()(98 lines) into focused methods under 50 lines each. Pure refactoring, no behavior changes.notify()_check_notify_preconditions()_build_payload_with_behavior()_set_payload_url()Test plan
test_status.py: 75/75 passedruff check+ruff format: passingMade with Cursor