refactor: consolidate TrialStatus to shared.plan.constants#702
Draft
thomasrockhu-codecov wants to merge 1 commit intorefactor/phase-0-enums-bulkfrom
Draft
refactor: consolidate TrialStatus to shared.plan.constants#702thomasrockhu-codecov wants to merge 1 commit intorefactor/phase-0-enums-bulkfrom
thomasrockhu-codecov wants to merge 1 commit intorefactor/phase-0-enums-bulkfrom
Conversation
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor/phase-0-enums-bulk #702 +/- ##
===============================================================
- Coverage 92.23% 92.23% -0.01%
===============================================================
Files 1303 1302 -1
Lines 47831 47708 -123
Branches 1619 1619
===============================================================
- Hits 44119 44004 -115
+ Misses 3403 3395 -8
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes |
TrialStatus already existed in shared.plan.constants (used by the API). Remove the duplicate from shared.django_apps.enums and point worker imports to the canonical location, eliminating redundancy. Co-authored-by: Cursor <cursoragent@cursor.com>
thomasrockhu-codecov
force-pushed
the
refactor/phase-0-enums-trialstatus
branch
from
cc9a07b to
71301fe
Compare
thomasrockhu-codecov
force-pushed
the
refactor/phase-0-enums-bulk
branch
from
7549d0c to
443fc35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TrialStatusfromshared.django_apps.enums— it already existed inshared.plan.constants(used by the API)shared.plan.constants.TrialStatusimportPart 2/3 of Phase 0. Stacked on #701.
Test plan
ruff checkpassesMade with Cursor