Skip to content

fix: change serializer to show enum for upload.state_name#784

Merged
thomasrockhu-codecov merged 1 commit intomainfrom
th/serialize-enum-upload-state-name
Mar 30, 2026
Merged

fix: change serializer to show enum for upload.state_name#784
thomasrockhu-codecov merged 1 commit intomainfrom
th/serialize-enum-upload-state-name

Conversation

@thomasrockhu-codecov
Copy link
Copy Markdown
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Mar 28, 2026

Updates the serializer to show as a ChoiceField in the API docs
image

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Low risk change limited to serializer field typing for API documentation; it should not affect persistence or processing logic, but could slightly change the OpenAPI schema/validation for state_name.

Overview
Updates the v2 commit uploads serializer so state_name is exposed as a ChoiceField backed by UploadState values (instead of a plain string), improving generated API docs and making the allowed states explicit.

Adds the UploadState import and keeps state_name read-only, still sourced from get_state_id_display.

Written by Cursor Bugbot for commit 1533dc9. This will update automatically on new commits. Configure here.

@sentry
Copy link
Copy Markdown
Contributor

sentry bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (13ff78c) to head (1533dc9).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #784   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1305     1305           
  Lines       47981    47982    +1     
  Branches     1636     1636           
=======================================
+ Hits        44263    44264    +1     
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
apiunit 96.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@thomasrockhu-codecov thomasrockhu-codecov added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit 8fb2b3e Mar 30, 2026
40 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/serialize-enum-upload-state-name branch March 30, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants