Conversation
nikandfor
force-pushed
the
nikandfor/compatible_install
branch
from
c393da9 to
4bad1df
Compare
rohitpaulk
reviewed
Nov 15, 2022
rohitpaulk
reviewed
Nov 15, 2022
rohitpaulk
reviewed
Nov 15, 2022
Contributor
Author
|
Added test workflow which runs the script with the dash shell. Dash is a minimalist POSIX-compliant shell. So no bash or anything specific features should pass the test. Update: |
Contributor
Author
|
sh is a link to dash in dockered ubuntu |
Member
|
Excellent idea to add a test script 🙂 |
rohitpaulk
approved these changes
Nov 16, 2022
nikandfor
force-pushed
the
nikandfor/compatible_install
branch
from
c1c3ef0 to
51f93b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked the script by shellcheck.
Changed chmod; mv to install. chmod can fail if +x mode is disabled for tmp directory.