Skip to content

Refactor codecrafters main.go: remove unused import and error variable, update usage instructions, and handle unknown command error. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohitpaulk merged 2 commits into from
Apr 30, 2024
Merged

Refactor codecrafters main.go: remove unused import and error variable, update usage instructions, and handle unknown command error. #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c39787
Refactor codecrafters main.go: remove unused import and error variabl…
rohitpaulk Apr 30, 2024
c099bfe
Refactor error message in run() function to suggest running codecraft…
rohitpaulk Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions cmd/codecrafters/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,13 @@ package main

import (
"context"
"errors"
"flag"
"fmt"
"os"

"github.com/codecrafters-io/cli/internal/commands"
"github.com/codecrafters-io/cli/internal/utils"
"github.com/fatih/color"
"github.com/rs/zerolog/log"
)

// Usage: codecrafters test
Expand All @@ -21,14 +19,18 @@ func main() {
flag.Usage = func() {
fmt.Fprintf(os.Stderr, `CLI to interact with CodeCrafters

VERSION
%s

USAGE
$ codecrafters [COMMAND]
$ codecrafters [command]

EXAMPLES
$ codecrafters test # Run tests without committing changes

COMMANDS
test: run tests on project in current directory
test: Run tests without committing changes
help: Show usage instructions

VERSION
%s
`, utils.VersionString())

}
Expand All @@ -50,7 +52,11 @@ COMMANDS
err := run()
if err != nil {
red := color.New(color.FgRed).SprintFunc()
fmt.Fprintf(os.Stderr, "%v\n", red(err))

if err.Error() != "" {
fmt.Fprintf(os.Stderr, "%v\n", red(err))
}

os.Exit(1)
}

Expand All @@ -73,10 +79,11 @@ func run() error {
"": // no argument
flag.Usage()
default:
log.Error().Str("command", cmd).Msgf("Unknown command. Did you mean to run \"codecrafters test\"?")
log.Info().Msg("Run codecrafters help for a list of available commands.")
red := color.New(color.FgRed).SprintFunc()
fmt.Printf(red("Unknown command '%s'. Did you mean to run `codecrafters test`?\n\n"), cmd)
fmt.Printf("Run `codecrafters help` for a list of available commands.\n")

return errors.New("bad usage")
return fmt.Errorf("")
}

return nil
Expand Down