Merged
Conversation
66db59c to
03d8890
Compare
…ts during installation. Updated messages to provide clearer instructions for entering admin passwords.
03d8890 to
a6f6576
Compare
Member
Author
|
Thanks to @dutch-casa for highlighting the issue! |
rohitpaulk
approved these changes
Jan 26, 2026
| fi | ||
|
|
||
| if ! mv "$TEMP_FOLDER/codecrafters" "$INSTALL_PATH" 2>/dev/null; then | ||
| echo -e "${MUTED}Note:${NC} You might need to enter your password to install." |
Member
There was a problem hiding this comment.
We're not sure if sudo will indeed prompt (sudo does use cached credentials at times) - let's stick to the original message and just say "You might need to enter your [OS_name] password to install."
…cations. Updated messages to emphasize potential password entry during installation, enhancing clarity for users.
d26bb5d to
194d4c3
Compare
|
Bugbot Autofix prepared a fix for the bug found in the latest run.
Preview (13f9ba5)diff --git a/install.sh b/install.sh
--- a/install.sh
+++ b/install.sh
@@ -80,14 +80,12 @@ tar xzf "$TEMP_FILE" -C "$TEMP_FOLDER" codecrafters
chmod 0755 "$TEMP_FOLDER/codecrafters"
if ! mkdir -p "$INSTALL_DIR" 2>/dev/null; then
- echo -e "${MUTED}Installing to $INSTALL_DIR. Admin access required.${NC}"
- echo "Enter your ${OS_NAME} user password to grant access."
+ echo -e "${MUTED}Note:${NC} You might need to enter your ${OS_NAME} user password to install."
sudo mkdir -p "$INSTALL_DIR"
fi
if ! mv "$TEMP_FOLDER/codecrafters" "$INSTALL_PATH" 2>/dev/null; then
- echo -e "${MUTED}Installing as $INSTALL_PATH. Admin access required.${NC}"
- echo "Enter your ${OS_NAME} user password to grant access."
+ echo -e "${MUTED}Note:${NC} You might need to enter your ${OS_NAME} user password to install."
sudo mv "$TEMP_FOLDER/codecrafters" "$INSTALL_PATH"
fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Context:
https://secure.helpscout.net/conversation/3209191583/11044?viewId=8414074
New prompt:
Note
Improves installer messaging to clarify which password is required during privileged operations.
OS_NAME("macOS"/"Linux") alongside existing OS detectionWritten by Cursor Bugbot for commit 194d4c3. This will update automatically on new commits. Configure here.