Merged
Conversation
- Fix Bug 1: Move return statement outside for loop in main.py (line 92) to process all background jobs instead of returning after the first one - Fix Bug 2: Add ExpectedOutputAndRegex() method to BackgroundJobStatusEntry to centralize job entry formatting logic. Update both CommandResponseWithReapedJobsTestCase and JobsBuiltinResponseTestCase to use the shared method, including proper 'Running' status handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a Python logic bug in job output generation and refactor Go test cases to centralize job entry formatting.
Note
Low Risk
Changes are limited to test helpers and a Python scenario shell; main risk is altering regex expectations for
jobs/reaped-job output formatting, which could change test outcomes.Overview
Centralizes
jobs/reaped-job output expectations in Go tests. AddsBackgroundJobStatusEntry.ExpectedOutputAndRegex()and updates bothJobsBuiltinResponseTestCaseandCommandResponseWithReapedJobsTestCaseto use it instead of duplicatingfmt/regex construction (including the special-case optional trailing&forRunning).Fixes a logic bug in the Python scenario
jobsoutput. Corrects indentation so thejobsbuiltin returns the full multi-line listing after iterating all background jobs, rather than returning early.Written by Cursor Bugbot for commit df90315. This will update automatically on new commits. Configure here.