Issue with Snapshot.parse regex - ERROR: Found orphan snapshots

[rogervinas]

Having a snapshot with a scenario and a body that contains something similar to [xxx]=yyy makes the Snapshot.parse regex fail, resulting in tests failing due to ERROR: Found orphan snapshots

Issue #178

Test shouldParseSnapshotWithScenarioAndBodyWithSomethingSimilarToAnScenarioToConfuseRegex will fail, one possible solution is to change the regex in Snapshot.parse:

from:

String regex = "^(?<name>.*?)(\\[(?<scenario>.*)\\])?=(?<header>\\{.*?\\})?(?<snapshot>(.*)$)";

to:

String regex = "^(?<name>.*?)(\\[(?<scenario>[^]]*)])?=(?<header>\\{[^}]*?})?(?<snapshot>(.*)$)";

See commit Improve regex and note the [^]]* in scenario group and [^}]* in header group, instead of just .*

[jackmatt2]

Can you run the following command and then push the files again?

./gradlew :java-snapshot-testing-core:spotlessApply

[rogervinas]

@jackmatt2 done!

[jackmatt2]

Thanks, I actually want to encode the body of the snapshot ... eventually which would make this PR unnecessary. However as a stopgap this is fine.