Skip to content

Adjust dark mode toggle position for mobile view#7

Merged
oohwooh merged 2 commits intocodeday:mainfrom
dotcomaki:main
Apr 3, 2026
Merged

Adjust dark mode toggle position for mobile view#7
oohwooh merged 2 commits intocodeday:mainfrom
dotcomaki:main

Conversation

@dotcomaki
Copy link
Copy Markdown
Contributor

Should be fine now!

image

@dotcomaki dotcomaki requested review from a team and oohwooh April 3, 2026 00:08
@dotcomaki dotcomaki added the bug Something isn't working label Apr 3, 2026
@oohwooh
Copy link
Copy Markdown
Member

oohwooh commented Apr 3, 2026

image

it looks kind of weird to me when scrolling down, maybe we should just add it as a menu item on mobile so it doesn't overlap with the content? or move it to the bottom right where it's less likely to be in the way of people reading

@dotcomaki
Copy link
Copy Markdown
Contributor Author

Fixed it! The position wasn't set as absolute, it goes away with the header when you scroll now

Copy link
Copy Markdown
Member

@oohwooh oohwooh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oohwooh oohwooh merged commit 169d536 into codeday:main Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants