Skip to content

Fix integer overflow in UCI go command #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codedeliveryservice merged 2 commits into from
Mar 19, 2026
Merged

Fix integer overflow in UCI go command #798

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8097727
Bench: 2795637
codedeliveryservice Mar 18, 2026
ebc86df
fix clippy
codedeliveryservice Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/uci.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,20 +349,20 @@ fn parse_limits(color: Color, tokens: &[&str]) -> Limits {

for chunk in tokens.chunks(2) {
if let [name, value] = *chunk {
let Ok(value) = value.parse() else {
let Ok(value) = value.parse::<u64>() else {
continue;
};

match name {
"depth" if value > 0 => return Limits::Depth(value),
"movetime" if value > 0 => return Limits::Time(value as u64),
"nodes" if value > 0 => return Limits::Nodes(value as u64),
"depth" if value > 0 => return Limits::Depth(value as i32),
"movetime" if value > 0 => return Limits::Time(value),
"nodes" if value > 0 => return Limits::Nodes(value),

"wtime" if Color::White == color => main = Some(value),
"btime" if Color::Black == color => main = Some(value),
"winc" if Color::White == color => inc = Some(value),
"binc" if Color::Black == color => inc = Some(value),
"movestogo" => moves = Some(value as u64),
"movestogo" => moves = Some(value),

_ => continue,
}
Expand All @@ -373,8 +373,8 @@ fn parse_limits(color: Color, tokens: &[&str]) -> Limits {
return Limits::Infinite;
}

let main = main.unwrap_or_default().max(0) as u64;
let inc = inc.unwrap_or_default().max(0) as u64;
let main = main.unwrap_or_default();
let inc = inc.unwrap_or_default();

match moves {
Some(moves) => Limits::Cyclic(main, inc, moves),
Expand Down
Loading