Merged
Conversation
houndci-bot
reviewed
Dec 2, 2016
util/util.go
Outdated
| return pidFilePath | ||
| } | ||
|
|
||
| // SpecFilepath returns the path to the REX-Ray spect file. |
There was a problem hiding this comment.
comment on exported function SpecFilePath should be of the form "SpecFilePath ..."
akutz
force-pushed
the
feature/auto-detect-running-service
branch
from
8cb65f1 to
c8348fb
Compare
codenrhoden
reviewed
Dec 2, 2016
util/util.go
Outdated
| return pidFilePath | ||
| } | ||
|
|
||
| // SpecFilePath returns the path to the REX-Ray spect file. |
Member
There was a problem hiding this comment.
minor typo in comment. "spect" vs "spec"
Member
Author
|
Oh come on. :) thanks for catching it :)
…--
-a
On Dec 2, 2016, at 5:21 PM, Travis Rhoden ***@***.***> wrote:
@codenrhoden commented on this pull request.
In util/util.go:
> }
return pidFilePath
}
+// SpecFilePath returns the path to the REX-Ray spect file.
minor typo in comment. "spect" vs "spec"
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
akutz
force-pushed
the
feature/auto-detect-running-service
branch
4 times, most recently
from
5322db1 to
242c77f
Compare
Current coverage is 8.46% (diff: 13.72%)@@ master #642 diff @@
========================================
Files 16 16
Lines 2087 2126 +39
Methods 0 0
Messages 0 0
Branches 0 0
========================================
+ Hits 177 180 +3
- Misses 1906 1942 +36
Partials 4 4
|
akutz
force-pushed
the
feature/auto-detect-running-service
branch
2 times, most recently
from
e261401 to
660c70e
Compare
This patch handles issue rexray#589 so that a REX-Ray client will automatically detect a running libStorage service if it was started by REX-Ray, even via embedded mode. This means that even if the REX-Ray configuration file relies on auto-service mode where a host is not explicitly defined, if a libStorage server is started in this manner, subsequent REX-Ray executions will not start additional servers, instead attaching to the existing service.
akutz
force-pushed
the
feature/auto-detect-running-service
branch
from
660c70e to
b8ef9e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch handles issue #589 so that a REX-Ray client will automatically detect a running libStorage service if it was started by REX-Ray, even via embedded mode. This means that even if the REX-Ray configuration file relies on auto-service mode where a host is not explicitly defined, if a libStorage server is started in this manner, subsequent REX-Ray executions will not start additional servers, instead attaching to the existing service.