Skip to content

Fix Duplicate Key#36

Merged
codedesignplus merged 9 commits intodevfrom
feature/fix-duplicate-key
Oct 31, 2024
Merged

Fix Duplicate Key#36
codedesignplus merged 9 commits intodevfrom
feature/fix-duplicate-key

Conversation

@codedesignplus
Copy link
Collaborator

This pull request includes several changes to the CI workflow configuration and improvements to the RabbitMQ and Vault services in the codebase. The most significant changes involve adding conditions to the CI workflow steps, introducing a generic parameter to the RabbitMQ service registration, and modifying the Vault service registration to conditionally add services based on configuration.

CI Workflow Enhancements:

  • Added conditions to run specific steps only if certain environment variables (IS_RELEASE, IS_RC, IS_BETA) are set, optimizing the CI workflow for different release stages. (.github/workflows/ci.yaml) [1] [2]

RabbitMQ Service Improvements:

  • Introduced a generic parameter TAssembly to the AddRabbitMQ method to specify the assembly containing domain events. (ServiceCollectionExtensions.cs) [1] [2]
  • Updated InitializeBackgroundService to use the generic parameter TAssembly for initializing RabbitMQ exchanges. (InitializeBackgroundService.cs) [1] [2]
  • Modified unit tests to accommodate the new generic parameter in the AddRabbitMQ method. (ServiceCollectionExtensionsTest.cs, RabbitPubSubServiceIntegrationTest.cs) [1] [2] [3] [4] [5] [6]

Vault Service Enhancements:

  • Added a condition to the AddVault method to register services only if the Enable option is set to true. (VaultExtensions.cs)
  • Introduced a new unit test to verify that services are not registered when the Enable option is false. (VaultExtensionsTest.cs)

Miscellaneous:

  • Removed unused using directives from VaultOptions.cs. (VaultOptions.cs)

@codedesignplus codedesignplus merged commit c4d9e35 into dev Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant