feat: add asynchronous DeleteAsync method to IRepositoryBase and impl…#83
Merged
codedesignplus merged 1 commit intodevfrom Feb 2, 2025
Merged
Conversation
…ement in RepositoryBase; include unit test for validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new asynchronous delete method for entities in the repository and includes corresponding tests. The most important changes are as follows:
New Method Addition:
DeleteAsync<TEntity>(Guid id, CancellationToken cancellationToken)method to theIRepositoryBaseinterface to allow deletion of an entity by its identifier asynchronously.DeleteAsync<TEntity>(Guid id, CancellationToken cancellationToken)method in theRepositoryBaseclass to support the new interface method.Testing:
DeleteAsync_WhenIdIsValidWithoutTenant_ReturnTrueinRepositoryBaseTest.csto verify that the new delete method works correctly when an entity is deleted by its identifier without a tenant.