Conversation
added 8 commits
April 12, 2017 16:10
Which implements ArrayAccess interface, and also removed not necessary anymore translateToAttributeName function from AttributeHelper, Cause it do nothing with AttributeHelper. And extended ProductAbstract from that Entity. That needs to create new classes and have option to just get column without writing any special SQL. So it’s simple ORM, I guess.
…e, otherwise it lost.
So, in magento, entities can be either attributes based, or flat.
Reason - we should not remove it like this, take a look on deleteCategories test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature closes #9 issue.