Skip to content

Conversation

@syha6821
Copy link

flush() now calls libftdi >= 1.5 tc[io]flush functions.
Closes #13

@codedstructure
Copy link
Owner

Thanks for this PR - looks useful and I appreciate that you've kept the code similar to the existing code.

One request though - as implemented the tests (e.g. make test) will typically fail. I also wonder if it should attempt the newer functions first (or even only?) since libftdi1.5 has been out a long time now.

@syha6821
Copy link
Author

I’ve amended the previous commit.
I’ve included the test code as well, and since the flush-related implementation in versions earlier than 1.5 contains bugs, it makes sense to support only version 1.5 and above, so I omitted the 1.4 code.

@syha6821 syha6821 changed the title Fix: flush() now calls libftdi >= 1.5 tc[io]flush functions. Fix: flush() now calls libftdi(>= 1.5) tc[io]flush functions. Apr 21, 2025
@codedstructure codedstructure merged commit a7cdf07 into codedstructure:main May 1, 2025
@codedstructure
Copy link
Owner

Thank you, this is a useful update to pylibftdi and will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flush now uses ftdi_tcioflush() when libftdi ≥ 1.5.

2 participants