Skip to content

angular 18 update complete#12

Merged
phoenixcoded20 merged 2 commits intomasterfrom
angular-18
Apr 30, 2024
Merged

angular 18 update complete#12
phoenixcoded20 merged 2 commits intomasterfrom
angular-18

Conversation

@phoenixcoded20
Copy link
Copy Markdown
Contributor

Commit Checklist

  • Remove UNUSED comment code
  • Remove any logging like console.log
  • Remove all warnings and errors while build
  • Check vulnerabilities
  • Make sure build for production is working. Try running command for prod build in local.
  • Fix prettier: npx prettier --write .
  • Fix eslint: npx eslint src\ --fix command
  • Push package.lock only if you used npm, push yarn.lock only if you used yarn. NPM will udpate both lock file so make sure you dont push yarn.lock updated by NPM
  • WCAG

General

  • Follow import structure. module/third-party/files/component/style/types/asset
  • Try to use theme for design like palette, typography, variant, components, etc. (don't use custom color code anyhow)
  • Before adding custom style follow our pre-built components/elements

@phoenixcoded20 phoenixcoded20 merged commit 5b76c09 into master Apr 30, 2024
@phoenixcoded20 phoenixcoded20 deleted the angular-18 branch April 30, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants