Handle branch name filter case-insensitively#5
Merged
arosloffdx merged 1 commit intomasterfrom Jul 12, 2022
Merged
Conversation
dylemma
approved these changes
Jul 11, 2022
Member
dylemma
left a comment
dylemma
left a comment
There was a problem hiding this comment.
This logic should probably be more sophisticated; see https://stackoverflow.com/questions/47298336/case-insensitive-string-matching-in-rust
Case-insensitive string ops are kinda nasty with edge cases. The to_lowercase approach will handle 99% of usage, but run into issues with certain non-english characters. I'm approving on behalf of the 99% but we may need to revisit this later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branches -n command was not treating the filter case-insensitively.