Feature/fileupload workflow #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the "TraceInputForm", which will contain separate (but similar) UIs for either uploading a new jar/war/zip for analysis or a .pulse file for import. The form lives on the landing page, and will eventually replace the "slide-out form" that came from the sidebar.
There are now two input forms: "New Trace" and "Import Trace". They have similar UIs, and can be accessed by tabs on the page. Each form sends data to its own URL, handled by the TraceFileUploadHandler.
I rearranged the state management of the form to use Bacon.js more centrally, and added a 'disabled' state to the OK button when the form is invalid. Also a couple of assorted small fixes like moving common.js to the common folder, and adding the missing 'header-push' div to the traces page.
Also added a separate button for "Import trace", next to the "New Trace" button.
Now when you pick a file, the browse/drag widgetry is hidden and the filename display is more emphasized. You can remove the file by clicking the 'x' button (or by canceling the form)
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a "create/import" form to the home page, replacing the old form that slid out of the trace list. The old "+ New Trace" button is now just a link to the home page. There is also a "+ Import Trace" button that leads to the same page but activates the import form's tab instead of the default one.