Add semantic accessors #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may be squashed together with `590688ef27d4ee377ef1ba589c096f2de6ae0dc2`.
inaki-amatria
requested review from
d-alonso and
jgonzac
and removed request for
a team
inaki-amatria
force-pushed
the
feature/AddSemanticAccessors
branch
2 times, most recently
from
7e51e0f to
65ac2ca
Compare
This is upstreamable.
inaki-amatria
force-pushed
the
feature/AddSemanticAccessors
branch
from
65ac2ca to
7028ea7
Compare
jgonzac
approved these changes
Mar 21, 2025
inaki-amatria
added a commit
that referenced
this pull request
Oct 24, 2025
- Patch #3 did not pass the internal testsuite - Patches #20 and stadelmanma#22 were merged together
inaki-amatria
added a commit
that referenced
this pull request
Oct 27, 2025
- Patch #3 did not pass the internal testsuite - Patches #20 and stadelmanma#22 were merged together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds semantic accessors to two
NAMEs in the AST. This PR also fixes theEND BLOCK DATAstatement so it supports all the variants accepted by the standard.